Reimplement NMS using morphological operations#1192
Merged
matlabbe merged 1 commit intointrolab:masterfrom Jan 2, 2024
Merged
Conversation
Member
|
The NMS version for SuperPoint Torch you are referring is this one? rtabmap/corelib/src/superpoint_torch/SuperPoint.cc Lines 168 to 192 in d135ef0 I am not using that much that code right now, but if you use it and know how to update it, you can make another PR. |
Contributor
Author
I don't use this part very much either. But I will test the new environment after upgrading my Jetson system to JetPack 6 in the near future and update this part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This borrows from the PyTorch implementation in SuperGlue, but uses this corrected version. This implementation is relatively simple, and since OpenCV has various optimizations for morphological operations, it will theoretically have better performance. But I haven't done any performance comparison testing yet. Since this is performed on heatmap, the NMS in SuperPoint Torch can be changed to PyTorch implementation. This way we can remove this part from util2d and introduce ANMS later.