CMake: Add compatibility for yaml-cpp 0.8.0.#1115
Merged
matlabbe merged 1 commit intointrolab:masterfrom Aug 19, 2023
FtZPetruska:fix-yaml-cpp
Merged
CMake: Add compatibility for yaml-cpp 0.8.0.#1115matlabbe merged 1 commit intointrolab:masterfrom FtZPetruska:fix-yaml-cpp
matlabbe merged 1 commit intointrolab:masterfrom
FtZPetruska:fix-yaml-cpp
Conversation
- Upstream uses YAML_CPP_INCLUDE_DIR - yaml-cpp 0.8.0 does not set YAML_CPP_LIBRARIES to the new target name. - Debug builds of yaml-cpp suffix the library with `d`.
7 tasks
Member
|
I also prefer usage of targets, thanks for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packaging yaml-cpp 0.8.0 on vcpkg, there were build issues with rtabmap.
Notably, the debug build fails due to
LIBRARIEShavingyaml-cpphardcoded, while yaml-cpp has a debug postfix. This, in combination with 0.8.0 renaming the target toyaml-cpp::yaml-cppmeans thatyaml-cppis treated as a literal library name.This PR updates the find logic to address these issues:
YAML_CPP_INCLUDE_DIR.yaml-cpp::yaml-cpp, but the variableYAML_CPP_LIBRARIESwas not updated. This issue has already been reported upstream, but when this specific version of yaml-cpp is found, just overwrite theYAML_CPP_LIBRARIESwith the correct target name.