Skip to content

Fixed build with gtsam 4.3.0#1033

Merged
matlabbe merged 2 commits intomasterfrom
matlabbe/1000-make-failed-gtsam-issue
May 14, 2023
Merged

Fixed build with gtsam 4.3.0#1033
matlabbe merged 2 commits intomasterfrom
matlabbe/1000-make-failed-gtsam-issue

Conversation

@matlabbe
Copy link
Copy Markdown
Member

No description provided.

@matlabbe matlabbe linked an issue May 14, 2023 that may be closed by this pull request
@matlabbe matlabbe merged commit 682d547 into master May 14, 2023
@matlabbe matlabbe deleted the matlabbe/1000-make-failed-gtsam-issue branch May 14, 2023 20:14
@wakoko79
Copy link
Copy Markdown

wakoko79 commented Apr 2, 2024

@matlabbe cc17ebe breaks gtsam 4.3.0 support.
At line 704 of rtabmap/corelib/src/optimizer/OptimizerGTSAM.cpp : gtsam::Values::iterator is used, but it only accessible with gtsam 4.1.1

matlabbe added a commit that referenced this pull request Apr 2, 2024
@matlabbe
Copy link
Copy Markdown
Member Author

matlabbe commented Apr 2, 2024

Should be fixed in 063ca9c, thx for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make failed, gtsam issue

2 participants