Merged
Conversation
…ger use GetCurrentByName just for getting the hash and code of a CodeUnit
…nes at the top of a .CLS version of a Python method, added unit test for that; also fixed error handling on the Python to CLS line mapping
… was 0, inconsequential fix so I'm just bundling it here
I accidentally pushed the listener change to the wrong branch
isc-tleavitt
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes related to Embedded Python:
Fixed bug ERROR #5002: ObjectScript error: UpdateComplexity+9^TestCoverage.Data.CodeUnit.1 <<==== FAILED
likely caused by circular dependencies involving the GetCurrentByName call in UpdateComplexity, by replacing calls to GetCurrentByName with calls to GetCurrentHash if possible, and also not calling UpdateComplexity unnecessarily.
Fixed mapping issue caused by empty lines at top of Python method not showing up in compiled Python. The error handling for inconsistent Python and CLS code is now working, and I also wrote a unit test for the empty line issue.