-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Enable Open Library to perform account activation + sign-in #10262
Copy link
Copy link
Closed
Labels
Affects: ExperienceIssues relating directly to service design & patrons experienceIssues relating directly to service design & patrons experienceLead: @jimchampIssues overseen by Jim (Front-end Lead, BookNotes) [managed]Issues overseen by Jim (Front-end Lead, BookNotes) [managed]Needs: BreakdownThis big issue needs a checklist or subissues to describe a breakdown of work. [managed]This big issue needs a checklist or subissues to describe a breakdown of work. [managed]Needs: Staff / InternalReviewed a PR but don't have merge powers? Use this.Reviewed a PR but don't have merge powers? Use this.Priority: 2Important, as time permits. [managed]Important, as time permits. [managed]Theme: OnboardingIssues relating to improving patrons discovery and usage of the websiteIssues relating to improving patrons discovery and usage of the websiteType: Feature RequestIssue describes a feature or enhancement we'd like to implement. [managed]Issue describes a feature or enhancement we'd like to implement. [managed]
Milestone
Metadata
Metadata
Assignees
Labels
Affects: ExperienceIssues relating directly to service design & patrons experienceIssues relating directly to service design & patrons experienceLead: @jimchampIssues overseen by Jim (Front-end Lead, BookNotes) [managed]Issues overseen by Jim (Front-end Lead, BookNotes) [managed]Needs: BreakdownThis big issue needs a checklist or subissues to describe a breakdown of work. [managed]This big issue needs a checklist or subissues to describe a breakdown of work. [managed]Needs: Staff / InternalReviewed a PR but don't have merge powers? Use this.Reviewed a PR but don't have merge powers? Use this.Priority: 2Important, as time permits. [managed]Important, as time permits. [managed]Theme: OnboardingIssues relating to improving patrons discovery and usage of the websiteIssues relating to improving patrons discovery and usage of the websiteType: Feature RequestIssue describes a feature or enhancement we'd like to implement. [managed]Issue describes a feature or enhancement we'd like to implement. [managed]
Type
Fields
Give feedbackNo fields configured for issues without a type.
Proposal
A new
xauthnendpoint that will enable the Internet Archive to send activation emails for Open Library patrons that perform activation + sign-on from openlibrary.orgIf the service is
openlibrary, the email should be updated point toopenlibrary.org/account/verifyhttps://git.archive.org/ia/petabox/-/blob/master/www/common/Account.inc#L605-622
When the patron clicks on the link, the functions here:
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/plugins/upstream/account.py#L627-L659
Should be replaced with a new
account/verify, which usesxauthnhttps://github.com/internetarchive/openlibrary/blob/master/openlibrary/accounts/model.py#L711-L751 toactivatethe account, as described in https://git.archive.org/ia/petabox/-/tree/master/www/common/XAuthn#activateJustification
Problem
Without this new flow, patrons are instead confusingly ping-ponged between services and requiring login multiple times.
More seamless onboarding experience.
Breakdown
@jimbonator has prototyped here:
https://git.archive.org/ia/petabox/-/commits/jim-xauthn-activate
Requirements Checklist
**xauthn**to include anactivatemethod that takes averification_tokenand enemail, verifies an account, and on success returns s3 credentials.openlibrary/openlibrary/plugins/upstream/account.py
Lines 514 to 548 in 5594cda
olpatrons to new openlibrary.org activate endpointRelated files
The files on petabox side are all in
www/common/XAuthn.Transaction.inccontains the code for handling the HTTP request and producing the appropriate response.PetaboxAccountProxy.incis where the verification could would live.Stakeholders