refactor lists_json_post in prep for fastapi (#11991)

RayBB · web-flow · commit bd0d7b868e3c · 2026-03-04T14:02:38.000-08:00
diff --git a/openlibrary/plugins/openlibrary/lists.py b/openlibrary/plugins/openlibrary/lists.py
@@ -552,7 +552,23 @@ def POST(self, user_key):
         data = self.loads(web.data())
         # TODO: validate data
 
-        seeds = self.process_seeds(data.get("seeds", []))
+        try:
+            result = self.process_new_list(user, data, site)
+        except ValueError as e:
+            if str(e) == "Spam list":
+                raise self.forbidden()
+            raise
+        except client.ClientException as e:
+            headers = {"Content-Type": self.get_content_type()}
+            err_data = {"message": str(e)}
+            raise web.HTTPError(e.status, data=self.dumps(err_data), headers=headers)
+
+        web.header("Content-Type", self.get_content_type())
+        return delegate.RawText(self.dumps(result))
+
+    @staticmethod
+    def process_new_list(user, data, site):
+        seeds = lists_json.process_seeds(data.get("seeds", []))
 
         lst = user.new_list(
             name=data.get("name", ""),
@@ -562,22 +578,14 @@ def POST(self, user_key):
         )
 
         if spamcheck.is_spam(lst):
-            raise self.forbidden()
+            raise ValueError("Spam list")
 
-        try:
-            result = site.save(
-                lst.dict(),
-                comment="Created new list.",
-                action="lists",
-                data={"list": {"key": lst.key}, "seeds": seeds},
-            )
-        except client.ClientException as e:
-            headers = {"Content-Type": self.get_content_type()}
-            data = {"message": str(e)}
-            raise web.HTTPError(e.status, data=self.dumps(data), headers=headers)
-
-        web.header("Content-Type", self.get_content_type())
-        return delegate.RawText(self.dumps(result))
+        return site.save(
+            lst.dict(),
+            comment="Created new list.",
+            action="lists",
+            data={"list": {"key": lst.key}, "seeds": seeds},
+        )
 
     @staticmethod
     def process_seeds(
