fix: change Len() return type from int to int64 to support large files#197
Merged
Conversation
NGTmeaty
approved these changes
Jun 3, 2026
NGTmeaty
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks good to me! Will do a full review in a little bit but thank you again!
Collaborator
|
@yzqzss If Zeno is compiled on a 64-bit system, doesn't it automatically use EDIT: I asked the question above because I was doubtful the 64-bit int needed to be explicit, but @NGTmeaty pointed out to me that FileInfo uses Int64 and so it makes sense to me that we explicitly use the same Int type |
willmhowes
approved these changes
Jun 4, 2026
Collaborator
|
(And, to be fair, it took a bit to wrap my head around it to figure that out 😄 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.