Safer ServerName extraction in the dialer#192
Merged
Conversation
Issue: dialer.go derived ServerName via string slicing (`address[:LastIndex(":")]`),
which is wrong for IPv6 and can mis-handle malformed addresses.
Fix: use `net.SplitHostPort` when possible.
Contributor
Author
|
AI also suggested using extra param: |
NGTmeaty
approved these changes
May 12, 2026
NGTmeaty
left a comment
Collaborator
There was a problem hiding this comment.
Good catch on the IPv6 addresses!
Handle error when extracting host from address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: dialer.go derived
ServerNamevia string slicing (address[:LastIndex(":")]), which is wrong for IPv6 and can mis-handle malformed addresses. Fix: usenet.SplitHostPortwhen possible.