Add fallback for DNS config#182
Merged
NGTmeaty merged 1 commit intoMar 6, 2026
Merged
Conversation
NGTmeaty
approved these changes
Mar 6, 2026
NGTmeaty
left a comment
Collaborator
There was a problem hiding this comment.
This is a great solution to the issue. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback mechanism in case loading the DNS configuration from
/etc/resolv.conffails.With this change, gowarc can now officially support Windows and potentially other operating systems or environments where
/etc/resolv.confis not available. Since the feature was developed and tested on Windows, Windows support is confirmed.Linux compatibility should not be affected, as systems with a valid
/etc/resolv.confwill continue using the standard DNS configuration.In the example code, a new variable
dnsFallbackis introduced, which defines adns.ClientConfigusing Cloudflare DNS servers.Fix #121
Example code