fixed README example and adjusted underlying implementation accordingly#147
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the README example code and adjusts the underlying implementation to support case-insensitive compression type handling. The changes ensure that the README example works correctly without panics and that compression types can be specified in lowercase.
- Fixed README example to access the correct ErrChan field and include missing imports
- Modified compression validation to be case-insensitive by converting input to lowercase
- Corrected variable assignment in the README example
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils.go | Updated compression validation to accept lowercase compression types and handle case-insensitive comparison |
| README.md | Fixed ErrChan access, added missing imports, and corrected variable assignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…nsitive validation.
Contributor
Author
|
hey @CorentinB , can you review the latest changes |
NGTmeaty
approved these changes
Oct 2, 2025
NGTmeaty
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #146: Issues with Example Usage in README
Description
This PR addresses several issues identified in the example usage provided in the README.
Fixes
1. ErrChan access
ErrChanfrom the proper struct field.client.Client.ErrChan, which does not exist.2. Compression setting causes panic
"gzip"or"zstd"are provided in lowercase.3. Missing imports
io,fmt,context) to the README example.