Skip to content

feat: ensure URL length does not exceed reasonable limits#596

Merged
NGTmeaty merged 5 commits into
mainfrom
fix-url-lengt
May 19, 2026
Merged

feat: ensure URL length does not exceed reasonable limits#596
NGTmeaty merged 5 commits into
mainfrom
fix-url-lengt

Conversation

@NGTmeaty

Copy link
Copy Markdown
Collaborator

No description provided.

@NGTmeaty NGTmeaty requested a review from willmhowes May 17, 2026 01:58
@codecov-commenter

codecov-commenter commented May 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.57%. Comparing base (b9fb5db) to head (4fff2f8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   56.41%   56.57%   +0.15%     
==========================================
  Files         133      133              
  Lines        6746     6749       +3     
==========================================
+ Hits         3806     3818      +12     
+ Misses       2561     2555       -6     
+ Partials      379      376       -3     
Flag Coverage Δ
e2etests 41.93% <33.33%> (+0.12%) ⬆️
unittests 29.13% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CorentinB

Copy link
Copy Markdown
Collaborator

See, I leave the Internet Archive and a year later I see PRs with "reasonable" in the title.. 😛

Comment thread internal/pkg/preprocessor/error.go Outdated
Comment thread internal/pkg/preprocessor/url_cgo.go Outdated

@willmhowes willmhowes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NGTmeaty NGTmeaty merged commit 51de717 into main May 19, 2026
5 checks passed
@NGTmeaty NGTmeaty deleted the fix-url-lengt branch May 19, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants