Add ItemFailed status when seencheck fails rather than panic#557
Merged
Conversation
This didn't work at some point... but should? We'll see!
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 56.66% 56.65% -0.02%
==========================================
Files 131 132 +1
Lines 6621 6718 +97
==========================================
+ Hits 3752 3806 +54
- Misses 2495 2536 +41
- Partials 374 376 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
panic: seed consistency check failed with err: child 4067f4c3-d22e-4fb3-88b3-80ca784bb805: item is not a seed and fresh but parent is not ItemGotChildren or ItemGotRedirected, seed id seed-54151
willmhowes
approved these changes
Feb 11, 2026
| } | ||
|
|
||
| // Debug print the seencheck response | ||
| // Debug print the seencheck request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently don't believe seencheck failing should result in a panic. This causes an incredible amount of pain when we can fail that specific item after 5 attempts.