Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where URL reset operations were failing during the shutdown process because they were using a cancelled global context. The fix creates a new context with a 1-minute timeout specifically for the reset operations during shutdown.
Key Changes:
- Creates a fresh context with timeout for reset operations during shutdown
- Applies the fix to both LQ and HQ source implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/pkg/source/lq/lq.go | Creates new context with timeout for resetURL calls during Stop() |
| internal/pkg/source/hq/hq.go | Creates new context with timeout for ResetURL calls during Stop() |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
+ Coverage 56.36% 56.61% +0.24%
==========================================
Files 130 130
Lines 8131 6481 -1650
==========================================
- Hits 4583 3669 -914
+ Misses 3184 2448 -736
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NGTmeaty
left a comment
There was a problem hiding this comment.
Appreciate it! Thank you!
Issue: the global ctx has been cancelled during the shutdown process,
ResetURL()has no chance to be issued.