Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 56.42% 56.55% +0.13%
==========================================
Files 131 131
Lines 6570 6572 +2
==========================================
+ Hits 3707 3717 +10
+ Misses 2488 2480 -8
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Update: Hmm, completely removing the cgo goada wasn't a good idea, since wasm has a much greater performance penalty than cgo. |
CGO_ENABLE=0
There was a problem hiding this comment.
Pull Request Overview
This PR enables Zeno to build and run without CGO by introducing a WebAssembly-based URL parser (goada-wasm) as an alternative to the CGO-dependent goada library. The change makes CGO optional rather than required, allowing the project to compile on systems without C++ compiler toolchains at the cost of reduced performance on non-amd64/arm64 architectures.
Key Changes:
- Added CGO-free URL parsing implementation using
goada-wasmpackage - Updated build process to test both CGO-enabled and CGO-disabled configurations
- Revised documentation to reflect that CGO is now optional
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/pkg/preprocessor/url_cgofree.go |
New CGO-free implementation of URL normalization using goada-wasm |
internal/pkg/preprocessor/url_cgo.go |
Added build tag and Backend() function to existing CGO implementation |
go.mod |
Added goada-wasm v1.0.1 dependency |
cmd/cmd.go |
Added URL parser backend information to CLI help output |
README.md |
Updated requirements section to document CGO as optional with performance tradeoffs |
.github/workflows/go.yml |
Enhanced CI to test both CGO-enabled and CGO-disabled builds |
.github/copilot-instructions.md |
Updated internal documentation to reflect optional CGO dependency |
NGTmeaty
left a comment
There was a problem hiding this comment.
So sorry for the delay here, been super busy! This is great! Thank you!
No description provided.