Biogrid extension and fix for deleted accounts#2396
Merged
sergiocontrino merged 5 commits intointermine:devfrom Dec 1, 2021
Merged
Biogrid extension and fix for deleted accounts#2396sergiocontrino merged 5 commits intointermine:devfrom
sergiocontrino merged 5 commits intointermine:devfrom
Conversation
added 5 commits
September 9, 2021 16:11
Member
|
tested with a build (biogrid for human and mouse) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Added the functionality to to set the gene.identifier to be the alias in the biogrid XML. Implemented for PombeMine where the xml is e.g.
ptc1
SPCC4F11.02
The configuration in the biogrid_cpnfig.properties file has been update adding the section:
pombe
4896.alias.primaryIdentifier = systematic name
4896.strain = 284812
Testing
I have tested in pombemine and it works. we need to test that it works also with the old configuration.
Testing on flymine or humanmine will be enough
Checklist
Before your pull request can be approved, be sure to check all boxes: