Skip to content

Biogrid extension and fix for deleted accounts#2396

Merged
sergiocontrino merged 5 commits intointermine:devfrom
danielabutano:biogrid
Dec 1, 2021
Merged

Biogrid extension and fix for deleted accounts#2396
sergiocontrino merged 5 commits intointermine:devfrom
danielabutano:biogrid

Conversation

@danielabutano
Copy link
Member

Details

Added the functionality to to set the gene.identifier to be the alias in the biogrid XML. Implemented for PombeMine where the xml is e.g.

ptc1
SPCC4F11.02

The configuration in the biogrid_cpnfig.properties file has been update adding the section:

pombe

4896.alias.primaryIdentifier = systematic name
4896.strain = 284812

Testing

I have tested in pombemine and it works. we need to test that it works also with the old configuration.
Testing on flymine or humanmine will be enough

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

@danielabutano danielabutano added this to the InterMine 5.0.4 milestone Nov 22, 2021
@danielabutano danielabutano changed the title Biogrid extension Biogrid extension and fix for deleted accounts Dec 1, 2021
@sergiocontrino
Copy link
Member

tested with a build (biogrid for human and mouse)

@sergiocontrino sergiocontrino merged commit 0997a5d into intermine:dev Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants