the change is fine, but i am not sure about the intended behaviour.
i thought it was solving a bug in filtering by organism, but this seems to work. if this is meant to allow matches with multi words terms, this can already be done enclosing them with " in the UI. I think that the default search behaviour is meant to have an OR between terms. is this we want to change?

Yes, I'm not totally sure this was what fixed the problem. If you like, I can retest with this update backed out.

hi @sammyjava , sorry for the long time it took us to check this! (it is again release time..)
if the issue was the faceting by organism, this is working in dev, so i think we can skip the PR. if the issue was to be able to search with multi-words terms i would probably use the " in the search box, but we can discuss with @rachellyne if this is the expected behaviour.
if i misunderstood just please let me know, i can implement and do the testing here (at last and at least..). thanks!

Sounds fine, I think I'll remove this update in my fork and see what happens that I didn't like before, if it happens. :)

i think we can close this, please reopen @sammyjava if needed. thanks!

I agree. :)

So, @danielabutano and @sergiocontrino a user noticed that a recent mine of mine doesn't properly facet on organism (built after I'd removed this change). I can confirm that this bug is reproduced in the current FlyMine and that this PR does, in fact, fix it on my mines.

1. Do a FlyMine keyword search on "glucose": you'll get 4930 results
2. Select R. norvegicus -- works correctly, you get 353 displayed results, all R. norvegicus. (But note that this is the only Rattus species in the mine.)
3. Unselect R. norvegicus and select D. pseudoobscura which should display only 31 results. But it displays 221 results for that and EVERY other species in Drosophila

This is, in fact our bug. We have several species within the same genus, and the Organism facet filter always returns all organisms within the chosen genus, because of this issue with the space in G. species that is fixed with this PR.

So, I'm going to add a PR again for a future update (the repo for this one is gone), I'll reference it below.