Allow arrays to be resolved as empty#83
Merged
intentor merged 2 commits intointentor:developfrom Mar 15, 2017
Merged
Conversation
Contributor
Author
|
Tweaked solution to check for the specific case of the property being an array of interfaces. |
Owner
|
Hello, @FodderMK! I do think your solution is very neat! That was a case I've never run into, however I believe is something to be addressed. Thank you! :D |
intentor
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't too sure about this one but wanted to make a pull request for it anyway. With the current implementation of Adic the following code causes a
InjectorException: Interface "TestGameRoot+IMockInterface" cannot be instantiated.exception:I understand the reasoning behind the error but I feel that in this situation the end result for the Test property should be an empty array (ie:
private IMockInterface[] Test = new IMockInterface[0]) This would fulfill theALWAYS_RESOLVErequirement (I have a property that has been resolved) while still fitting in with my configuration (noIMockInterfaceclasses defined). This pull request accomplishes that functionality.This situation has come up because I have platform-specific classes bound to
IMockInterface, and in some cases the platform doesn't need anIMockInterfacedefinition. Currently I need to create a fake class likepublic class NullClass : IMockInterfaceto have my game run and that doesn't seem correct.If you would like more details let me know.