Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1865 +/- ##
===========================================
+ Coverage 66.75% 76.25% +9.50%
===========================================
Files 95 382 +287
Lines 3706 12502 +8796
Branches 519 1316 +797
===========================================
+ Hits 2474 9534 +7060
- Misses 941 2427 +1486
- Partials 291 541 +250
... and 194 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
start.py
Outdated
| required=False, | ||
| type=generic_version_regex, | ||
| default=PYCTI_DEFAULT_VERSION, | ||
| help=f"The pycti version to choose. This must match the OpenCTI server version" |
Contributor
There was a problem hiding this comment.
Suggested change
| help=f"The pycti version to choose. This must match the OpenCTI server version" | |
| help="The pycti version to choose. This must match the OpenCTI server version" |
f-string is unnecessary here. This can just be a string. More info.
start.py
Outdated
| type=generic_version_regex, | ||
| default=PYCTI_DEFAULT_VERSION, | ||
| help=f"The pycti version to choose. This must match the OpenCTI server version" | ||
| f" you are connecting to." |
Contributor
There was a problem hiding this comment.
Suggested change
| f" you are connecting to." | |
| " you are connecting to." |
Again, f-string is unnecessary here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.