fix: union instead of replace for include_similar in command_sequence…#992
Merged
regulartim merged 1 commit intointelowlproject:developfrom Mar 9, 2026
Conversation
…_view Signed-off-by: Sanchit2662 <sanchit2662@gmail.com>
14 tasks
Contributor
Author
|
@regulartim , please review the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found a bug in the command sequence API where using
include_similar=trueactually made the results worse instead of better , it was losing data instead of extending it.The problem: when I query an IP with
include_similar=true, the API was throwing away the exact matches and only returning cluster-based results. If a command sequence had no cluster assigned, I'd get nothing back even though there should be results.What I Changed
I rewrote lines 69-73 in
command_sequence_viewto use.union()instead of reassigning the queryset. This matches howcowrie_session_viewalready handles the same flag correctly.Tests
Added two tests to catch this regression:
include_similarresults include the base results (never lose data)Fixes #985
Type of change
Checklist
Formalities
<feature name>. Closes #999develop.develop.Docs and tests
Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.