test: add test coverage for tasks.py wrapper functions. Closes #964#973
Merged
regulartim merged 2 commits intoGreedyBear-Project:developfrom Mar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing unit tests to fully cover greedybear/tasks.py lazy wrapper functions, raising file coverage to 100%.
Changes:
- Introduce a new
TestTaskssuite covering each wrapper task’s execution path. - Add dedicated test for
train_and_updateto validate trainer/updater orchestration. - Add enable/disable tests for
cluster_commandsbehavior gated byCLUSTER_COWRIE_COMMAND_SEQUENCES.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
hi @regulartim the PR is ready for review. Please review this when you get time. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added complete test coverage for
greedybear/tasks.py. The file was previously at ~41% coverage, with onlyextract_allcovered. This PR introduces missing tests for all remaining lazy wrapper tasks, bringing the coverage forgreedybear/tasks.pyto 100%.Related issues
Closes #964: Tests: Add test coverage for untested tasks in greedybear/tasks.py
Type of change
Checklist
Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.
Formalities
<feature name>. Closes #999develop.develop.Docs and tests
Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.GUI changes
Ignore this section if you did not make any changes to the GUI.