Skip to content

feat(feeds): display country info in details popover. Closes #549#954

Merged
regulartim merged 3 commits intoGreedyBear-Project:developfrom
lvb05:549-country-in-details
Mar 5, 2026
Merged

feat(feeds): display country info in details popover. Closes #549#954
regulartim merged 3 commits intoGreedyBear-Project:developfrom
lvb05:549-country-in-details

Conversation

@lvb05
Copy link
Copy Markdown
Contributor

@lvb05 lvb05 commented Mar 4, 2026

Description

Added GeoIP country information to the existing "Details" column popover
in the Feeds table, under the Enrichment section. When country data is
available for an IOC, it is displayed as "Country: ". When unavailable,
it falls back to "-".

Related issues

Closes #549
Depends on #524

Type of change

  • New feature (non-breaking change which adds functionality).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • I chose an appropriate title for the pull request in the form: <feature name>. Closes #999
  • My branch is based on develop.
  • The pull request is for the branch develop.
  • I have reviewed and verified any LLM-generated code included in this PR.

Docs and tests

  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved.
  • All the tests gave 0 errors.

GUI changes

Ignore this section if you did not make any changes to the GUI.

  • I have provided a screenshot of the result in the PR.
  • I have created new frontend tests for the new component or updated existing ones.

Copilot AI review requested due to automatic review settings March 4, 2026 18:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GeoIP country information to the Feeds table “Details” popover under the Enrichment section.

Changes:

  • Render a new “Country” line in the Details popover content.
  • Add frontend tests covering presence/absence of the country field in the popover.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
frontend/src/components/feeds/tableColumns.jsx Adds a “Country” row to the Details popover enrichment section.
frontend/tests/components/feeds/TableColumns.test.jsx Adds tests asserting the country line renders with a value or falls back to “-”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/tests/components/feeds/TableColumns.test.jsx
Comment thread frontend/src/components/feeds/tableColumns.jsx Outdated
Comment thread frontend/src/components/feeds/tableColumns.jsx Outdated
Comment thread frontend/tests/components/feeds/TableColumns.test.jsx
@regulartim
Copy link
Copy Markdown
Collaborator

Hey @lvb05 ! Pleas add a screenshot of your change.

Copilot AI review requested due to automatic review settings March 4, 2026 18:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lvb05
Copy link
Copy Markdown
Contributor Author

lvb05 commented Mar 5, 2026

  • Tests
Screenshot 2026-03-05 172011
Screenshot 2026-03-05 171851

Copy link
Copy Markdown
Collaborator

@regulartim regulartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! :)

@regulartim regulartim merged commit 0ddc0be into GreedyBear-Project:develop Mar 5, 2026
8 of 9 checks passed
cclts pushed a commit to cclts/GreedyBear that referenced this pull request Mar 11, 2026
…ar-Project#549 (GreedyBear-Project#954)

* feat(feeds): display country in details popover

* Replace 'country' with 'attacker_country' in table

* Update TableColumns.test.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants