Skip to content

Fix Docker regressions from PR #890. Closes #898#900

Merged
regulartim merged 4 commits intodevelopfrom
fix_stag
Feb 27, 2026
Merged

Fix Docker regressions from PR #890. Closes #898#900
regulartim merged 4 commits intodevelopfrom
fix_stag

Conversation

@regulartim
Copy link
Copy Markdown
Collaborator

@regulartim regulartim commented Feb 27, 2026

Description

This fixes some Docker related issues introduced in #890:

  • add libexpat1 to Dockerfile runtime dependencies (required by pyuwsgi)
  • healthcheck now hits uWSGI stats endpoint (port 1717) instead of uWSGI protocol socket (port 8001)
  • only load django_watchfiles when DJANGO_TEST_SERVER=True, not just DEBUG=True
  • add die-on-term to uWSGI config for clean container shutdown

The first two actually caused the failed starts. I missed these in #890 because I made wrong assumptions during testing. Hope this will fix it.

Related issues

#898

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Chore (refactoring, dependency updates, CI/CD changes, code cleanup, docs-only changes).

Checklist

Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.

Formalities

  • I have read and understood the rules about how to Contribute to this project.
  • I chose an appropriate title for the pull request in the form: <feature name>. Closes #999
  • My branch is based on develop.
  • The pull request is for the branch develop.
  • I have reviewed and verified any LLM-generated code included in this PR.

Docs and tests

  • I documented my code changes with docstrings and/or comments.
  • I have checked if my changes affect user-facing behavior that is described in the docs. If so, I also created a pull request in the docs repository.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved.
  • All the tests gave 0 errors.

GUI changes

Ignore this section if you did not make any changes to the GUI.

  • I have provided a screenshot of the result in the PR.
  • I have created new frontend tests for the new component or updated existing ones.

Review process

  • We encourage you to create a draft PR first, even when your changes are incomplete. This way you refine your code while we can track your progress and actively review and help.
  • If you think your draft PR is ready to be reviewed by the maintainers, click the corresponding button. Your draft PR will become a real PR.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem.
  • Every time you make changes to the PR and you think the work is done, you should explicitly ask for a review. After receiving a "change request", address the feedback and click "request re-review" next to the reviewer's profile picture at the top right.

@regulartim regulartim marked this pull request as ready for review February 27, 2026 19:09
@regulartim regulartim merged commit bf91ee9 into develop Feb 27, 2026
4 checks passed
@regulartim regulartim deleted the fix_stag branch February 27, 2026 19:10
cclts pushed a commit to cclts/GreedyBear that referenced this pull request Mar 11, 2026
…ear-Project#898 (GreedyBear-Project#900)

* add libexpat1 as a runtime requirement again

* use different health checks for uWSGI and Django dev server

* only add django_watchfiles to installed apps when Django test server is running

* make uWSGI stop gracefully on SIGTERM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant