refactor : honeypot creation and enforce case-insensitive uniqueness . Closes #689#693
Merged
regulartim merged 4 commits intointelowlproject:developfrom Jan 13, 2026
Conversation
drona-gyawali
commented
Jan 9, 2026
Collaborator
|
Hey @drona-gyawali ! :) Independent of the review I wanted to ask you why you think that this is a breaking change? What exactly will break, when we merge this? |
regulartim
requested changes
Jan 10, 2026
Collaborator
regulartim
left a comment
There was a problem hiding this comment.
I have some problems with the current version of the code. Also, could you add a test case that tests the unique constraint?
Contributor
Author
Thanks for pointing that out :) |
drona-gyawali
commented
Jan 12, 2026
regulartim
requested changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues with honeypot creation and ensures case-insensitive uniqueness:
Related issues
closes #689
Type of change
Please delete options that are not relevant.
Checklist
develop.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.Important Rules