refactor: cleanup ruff ignores and fix N818. Closes #640#692
Merged
mlodic merged 2 commits intointelowlproject:developfrom Jan 9, 2026
Merged
refactor: cleanup ruff ignores and fix N818. Closes #640#692mlodic merged 2 commits intointelowlproject:developfrom
mlodic merged 2 commits intointelowlproject:developfrom
Conversation
- Rename ElasticServerDownException → ElasticServerDownError (N818) - Remove N804, N818, UP008, UP031 from ignores as they are fixed - Codebase is now compliant with these rules
- Rename ElasticServerDownException → ElasticServerDownError (N818)
- Replace dict() with {} (C408)
- Remove N804, N818, UP008, UP031, C401, C408 from ignores
- Codebase is now compliant with these rules
- Verified all checks pass with explicit config
Contributor
Author
|
I also noticed there were only 2 occurrences of |
Contributor
Author
|
Remaining Ignores (17 violations):
The codebase is now fully aligned with the updated Ruff configuration! |
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR finalizes the Ruff migration by addressing the remaining "safe to fix" rules that were previously ignored.
ElasticServerDownExceptiontoElasticServerDownErroringreedybear/cronjobs/repositories/elastic.pyand updated usages. This exception is internal, so renaming is safe.N804,N818,UP008, andUP031from the ignore list in.ruff.tomlas the codebase is now fully compliant with these rules.Related issues
Follow-up to #663 (Ruff migration)
#640
Type of change
Checklist
develop.Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.