Description

Fixes all remaining flake8-django violations and enables enforcement of DJ001, DJ008, and DJ012 rules.

Changes Overview

Phase 1: DJ008/DJ012 - Model str and Field Ordering

Phase 2: DJ001 - CharField null=True Violations

Model Changes:

• FireHolList.source: Changed from null=True to blank=True, default=""
• MassScanner.reason: Changed from null=True to blank=True, default=""

Logic Updates:
Updated get_firehol_categories() to filter empty source strings:

# Filter out empty strings from exact matches
firehol_categories.extend([source for source in exact_matches if source])

# Check entry.source is not empty before adding to network matches
if extracted_ip in network_range and entry.source and entry.source not in firehol_categories:

Why this matters: The maintainer requested that empty source values shouldn't pollute the firehol_categories list. This ensures that after migration from null=True to default='', the behavior remains correct.

Database Migration: Created migration 0026_fix_charfield_null_true.py to update schema.

Phase 3: Enable Enforcement

Related issues

Part of the Ruff migration series following #663, #671, #677 and #681. This is the final cleanup issue for Django-specific anti-patterns.

Type of change

• Bug fix (non-breaking change which fixes an issue).

Checklist

• I have read and understood the rules about how to Contribute to this project.
• The pull request is for the branch develop.
• I have added documentation of the new features.
• Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
• All the tests (old ones) gave 0 errors.
• If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).