Also: do you think you can write a test for that?

And another thing: would you add headers to the request, such that the alerts have a prettier format? Suggestion (feel free to improve):

headers={
        "Title": "GreedyBear error",
        "Tags": "warning"
    })

Good job, I like it! 👍 Could you please add a set of test cases for send_ntfy_message?

Just to be sure, do you mean add a testing python script like the ones in the test folder?

Just to be sure, do you mean add a testing python script like the ones in the test folder?

Yes, exactly. It should cover happy paths, failing paths, edge cases. Just take a look at a few existing tests to get an impression.

@HARSHVARANDANI Fix the formatting such that the CI is happy, then we can merge.

Fix the formatting such that the CI is happy, then we can merge.

@regulartim I have already used pre-commit before every commit to check for the formatting Black, Flake and Isort, is there anything else there is supposed to be done for the formatting?

Ok, that's strange. Maybe this is because of the ongoing migration to Ruff. I'll check and get back to you.

Now ruff is unhappy with the import ordering and I don't know why. I cloned @HARSHVARANDANI 's repo and ran ruff using our .ruff.toml from the develop branch. It did not complain about anything. Can you please help @mlodic @opbot-xd ?

I tried it locally and I correctly replicate the error reported by the CI. Ruff is working fine in my env. How did you install pre-commit/ruff in your env?

So yes, the error must be fixed

from unittest.mock import MagicMock, patch

from django.test import SimpleTestCase, override_settings

from greedybear.ntfy import send_ntfy_message

TEST_LOGGING = {

after then on running the check again, all checks passed
so try this once
since i did not have the push access so was not able to push my code changes

ah you know what? It could be that you executed the ruff linter instead of the ruff formatter. Those are 2 different commands. @regulartim
To be sure to execute all of them, please run pre-commit run ruff --all-files -c .github/.pre-commit-config.yaml

Sorry, my bad. I ran ruff format instead of ruff check. Thanks @mlodic @opbot-xd !

Now the CI is happy! Thanks for your work @HARSHVARANDANI, I 'll merge now.