Merged
Conversation
mlodic
approved these changes
Dec 23, 2025
Collaborator
mlodic
left a comment
There was a problem hiding this comment.
thanks for taking care of this! these tasks are really important to catch unexpected errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I adapted two monitoring jobs to the repository pattern introduced in #624 :
Should have done this in #624 , sorry about that.
Note: in MonitorHoneypots I intentionally ignored Cowrie and Log4j since they will be in the GeneralHoneypot table soon anyway.
Also note: I did not write tests for the new methods yet. I will open an issue for that since we have a lot of new contributors and writing tests is a good first issue in my opinion.
Related issues
Type of change
Please delete options that are not relevant.
Checklist
develop.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.Important Rules