Skip to content

Fix monitoring jobs. Closes #648#651

Merged
regulartim merged 5 commits intodevelopfrom
fix_monitoring_jobs
Dec 23, 2025
Merged

Fix monitoring jobs. Closes #648#651
regulartim merged 5 commits intodevelopfrom
fix_monitoring_jobs

Conversation

@regulartim
Copy link
Copy Markdown
Collaborator

@regulartim regulartim commented Dec 23, 2025

Description

I adapted two monitoring jobs to the repository pattern introduced in #624 :

  • MonitorHoneypots
  • MonitorLogs

Should have done this in #624 , sorry about that.

Note: in MonitorHoneypots I intentionally ignored Cowrie and Log4j since they will be in the GeneralHoneypot table soon anyway.

Also note: I did not write tests for the new methods yet. I will open an issue for that since we have a lot of new contributors and writing tests is a good first issue in my opinion.

Related issues

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • The pull request is for the branch develop.
  • I have added documentation of the new features.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@regulartim regulartim requested a review from mlodic December 23, 2025 16:10
@regulartim regulartim marked this pull request as ready for review December 23, 2025 16:13
Copy link
Copy Markdown
Collaborator

@mlodic mlodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this! these tasks are really important to catch unexpected errors

@regulartim regulartim merged commit 8bde224 into develop Dec 23, 2025
5 checks passed
@regulartim regulartim deleted the fix_monitoring_jobs branch February 25, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants