Fix negative predictions in Feeds API#626
Merged
regulartim merged 1 commit intointelowlproject:developfrom Dec 19, 2025
Merged
Conversation
- Enforce non-negative predictions in Regressor.predict using np.maximum - Add test case in TestRegressor to verify negative values are clipped - Fixes issue with negative expected_interactions causing API errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
RandomForestRegressormodel could occasionally produce negative values forexpected_interactionsdue to specific training data patterns (negative deltas). This caused HTTP 400 errors in the Feeds API because the field requires values >= 0.This PR implements a fix by clipping the output of the
Regressor.predictmethod to be non-negative usingnp.maximum(predictions, 0).A test case (test_negative_predictions) was added to TestRegressor to verify this behavior.
Related issues
Closes #625
Type of change
Checklist
develop.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.