Conversation
regulartim
reviewed
Jul 18, 2025
Comment on lines
+76
to
+82
| if not settings.THREATFOX_API_KEY: | ||
| self.log.warning("Threatfox API Key not available") | ||
| return | ||
|
|
||
| # we submit only payload request IOCs for now cause they are more reliable | ||
| if not ioc_record.payload_request: | ||
| return |
Collaborator
There was a problem hiding this comment.
I think it would be better to first check if not ioc_record.payload_request and then not settings.THREATFOX_API_KEY. This would drastically reduce the amount of log messages, right?
Collaborator
There was a problem hiding this comment.
Or, alternatively, call _threatfox_submission from _extract_possible_payload_in_messages in cowrie.py to make sure it is only called for payload requests?
Member
Author
There was a problem hiding this comment.
I'll do the change you first suggested. I wanted to put this here so that it will be extendable for the future in case we are able to integrate other honeypots effectively like we did for cowrie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solving this: #517