Skip to content

Remove duplicate values from Feeds API. Closes #485#486

Merged
mlodic merged 4 commits intointelowlproject:developfrom
regulartim:remove_dup_vals
Mar 2, 2025
Merged

Remove duplicate values from Feeds API. Closes #485#486
mlodic merged 4 commits intointelowlproject:developfrom
regulartim:remove_dup_vals

Conversation

@regulartim
Copy link
Copy Markdown
Collaborator

@regulartim regulartim commented Feb 28, 2025

Description

Removes the "honeypots" field from Feeds API.

Related issues

#485

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • The pull request is for the branch develop.
  • I have added documentation of the new features.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@regulartim regulartim marked this pull request as ready for review February 28, 2025 08:59
@mlodic
Copy link
Copy Markdown
Member

mlodic commented Mar 2, 2025

@drosetti please check that in other private projects there are no reference to this removed field. In case, adjust the reference from honeypot to feed_type

@mlodic mlodic merged commit 16e0da3 into intelowlproject:develop Mar 2, 2025
5 checks passed
@regulartim
Copy link
Copy Markdown
Collaborator Author

For context: I added that "honeypots" field a few weeks ago for my work on the ML models.

@regulartim regulartim deleted the remove_dup_vals branch March 2, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants