[SYCL] Refactor SYCL path for work_group_size_hint#7961
Merged
bader merged 3 commits intointel:syclfrom Jan 11, 2023
Merged
Conversation
This commit refactors the SYCL path for work_group_size_hint, similar to the refactoring for reqd_work_group_size in intel#7450. It also fixes an issue where the dimensions of the work-group hint were not correctly reversed. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
smanna12
reviewed
Jan 9, 2023
premanandrao
approved these changes
Jan 9, 2023
Contributor
premanandrao
left a comment
There was a problem hiding this comment.
I just had minor comments/nits.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the SYCL path for work_group_size_hint, similar to the refactoring for reqd_work_group_size in
#7450. It also fixes an issue where the dimensions of the work-group hint were not correctly reversed.