[SYCL] Add assert for LangOpts and ParseKind in LanguageOptionsSpecificAttr#7947
Merged
bader merged 1 commit intointel:syclfrom Jan 9, 2023
Merged
Conversation
…icAttr This commit adds asserts that all attributes deriving from LanguageOptionsSpecificAttr define both a ParseKind and a LangOpts value. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
premanandrao
approved these changes
Jan 9, 2023
Contributor
premanandrao
left a comment
There was a problem hiding this comment.
I haven't ever come to this part of the code before. With that caveat, this change looks okay to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds asserts that all attributes deriving from LanguageOptionsSpecificAttr define both a ParseKind and a LangOpts value.
Based on #7450 (comment)