[NFC][SYCL][Graph] Remove outdated comment#18860
Merged
aelovikov-intel merged 1 commit intointel:syclfrom Jun 10, 2025
Merged
Conversation
Since intel#16154 merged in November 2024 we have required a device to report the `UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE` capability to support the `ext_oneapi_graph` aspect. Removing the comment was missed in that change, remove now since it caught my eye.
Contributor
Author
|
@intel/llvm-reviewers-runtime This should be a trivial review, thanks |
sarnex
approved these changes
Jun 10, 2025
aelovikov-intel
approved these changes
Jun 10, 2025
uditagarwal97
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #16154 merged in November 2024 we have required a device to report the
UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLEcapability to support theext_oneapi_graphaspect.Removing the comment was missed in that change, remove now since it caught my eye.