[SYCL] Fix deferred buf destruction regression caused by host device removal#14396
Merged
sarnex merged 6 commits intointel:syclfrom Jul 3, 2024
Merged
[SYCL] Fix deferred buf destruction regression caused by host device removal#14396sarnex merged 6 commits intointel:syclfrom
sarnex merged 6 commits intointel:syclfrom
Conversation
…ce removal Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
This was referenced Jul 2, 2024
Contributor
|
I'm not familiar with neither this area nor the previous PR... Adding @sergey-semenov |
Contributor
Author
|
fixes #14397 |
sergey-semenov
approved these changes
Jul 3, 2024
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
sarnex
approved these changes
Jul 3, 2024
Contributor
sarnex
left a comment
There was a problem hiding this comment.
test changes LGTM
@KseniyaTikhomirova What is your confidence that this change fixes the cause of the hang? If we don't have very high confidence and re-enable the tests, it could break the CI again.
Thanks.
Contributor
Author
I was able to reproduce hang on local WIN Gen9 system and with this fix tests passed |
Contributor
|
Ok, sounds legit to me, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.