Skip to content

[SYCL] Simplify handing of builtins in LowerWGScope#1399

Merged
bader merged 1 commit intointel:syclfrom
codeplaysoftware:victor/hier_fixes
Mar 27, 2020
Merged

[SYCL] Simplify handing of builtins in LowerWGScope#1399
bader merged 1 commit intointel:syclfrom
codeplaysoftware:victor/hier_fixes

Conversation

@Naghasan
Copy link

Implements a few code simplification/unification for LowerWGScope

Signed-off-by: Victor Lomuller victor@codeplay.com

@bader bader requested review from againull and kbobrovs March 26, 2020 14:05
@Naghasan Naghasan force-pushed the victor/hier_fixes branch from bf084d9 to f5a102f Compare March 26, 2020 14:12
@bader
Copy link
Contributor

bader commented Mar 26, 2020

I wonder what "fix" mean in the title. Do you have a regression test which exposes the problem?

@Naghasan Naghasan changed the title [SYCL] Simplify and fix handing of builtins in LowerWGScope [SYCL] Simplify handing of builtins in LowerWGScope Mar 27, 2020
@Naghasan Naghasan force-pushed the victor/hier_fixes branch from f5a102f to c6cb179 Compare March 27, 2020 13:33
Signed-off-by: Victor Lomuller <victor@codeplay.com>
@Naghasan Naghasan force-pushed the victor/hier_fixes branch from c6cb179 to 9fdb509 Compare March 27, 2020 13:54
@bader bader merged commit dc7d851 into intel:sycl Mar 27, 2020
@bader bader added the cuda CUDA back-end label Mar 27, 2020
@Naghasan Naghasan deleted the victor/hier_fixes branch March 27, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda CUDA back-end

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants