[SYCL][NFC] Doxygen doc for CUDA backend#1394
Merged
bader merged 1 commit intointel:syclfrom Mar 27, 2020
Merged
Conversation
sycl/plugins/cuda/pi_cuda.hpp
Outdated
Contributor
There was a problem hiding this comment.
Should it be /// to align with the rest of project?
romanovvlad
reviewed
Mar 26, 2020
romanovvlad
previously approved these changes
Mar 27, 2020
Contributor
romanovvlad
left a comment
There was a problem hiding this comment.
LGTM. @alexbatashev are you OK with the patch?
alexbatashev
previously approved these changes
Mar 27, 2020
Contributor
alexbatashev
left a comment
There was a problem hiding this comment.
LGTM, please, sign-off your commits
Adding doxygen documentation to PI CUDA backend. Some code is re-ordered in the file to help sorting the doxygen. Co-Authored-By: Alexey Bader <alexey.bader@intel.com> Co-Authored-By: Alexander Batashev <alexbatashev@outlook.com> Co-Authored-By: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com> Signed-off-by: Ruyman Reyes <ruyman@codeplay.com>
bader
approved these changes
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding doxygen documentation to PI CUDA backend.
Some code is re-ordered in the file to help sorting the doxygen.