[SYCL] Delete the workaround for wrong s_upsample mangling#1053
Merged
bader merged 1 commit intointel:syclfrom Feb 25, 2020
imashkov:private/imashkov/delete_workaround
Merged
[SYCL] Delete the workaround for wrong s_upsample mangling#1053bader merged 1 commit intointel:syclfrom imashkov:private/imashkov/delete_workaround
bader merged 1 commit intointel:syclfrom
imashkov:private/imashkov/delete_workaround
Conversation
AlexeySachkov
previously approved these changes
Jan 24, 2020
Fznamznon
reviewed
Jan 24, 2020
Contributor
Fznamznon
left a comment
There was a problem hiding this comment.
Could you please rework your patch title and provide description?
What is the workaround?
What is the closed issue?
It's confusing.
Contributor
Author
|
Patch can not be merged yet, fpga emulator test fell. Close this pull request until fix is in runtime. |
Contributor
Author
|
Same pull request passed all checks in private repo, so after all successful checks here it can be merged |
We had issue with wrong mangling of s_upsample. I fixed it a long time ago, so we can delete workaround now. Signed-off-by: Ilya Mashkov <ilya.mashkov@intel.com>
Contributor
Author
|
@bader this pull request is ready to be merged, please do it, when you have time. |
AlexeySachkov
approved these changes
Feb 25, 2020
Contributor
It wasn't really ready without approval, fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Mashkov ilya.mashkov@intel.com