Skip to content

Add cargo.toml formatting with taplo#998

Merged
haerdib merged 6 commits intomasterfrom
ec_taplo
Sep 28, 2022
Merged

Add cargo.toml formatting with taplo#998
haerdib merged 6 commits intomasterfrom
ec_taplo

Conversation

@echevrier
Copy link
Contributor

@echevrier echevrier commented Sep 14, 2022 •
edited
Loading

@echevrier echevrier marked this pull request as draft September 14, 2022 09:23
@echevrier echevrier requested review from clangenb, haerdib and murerfel and removed request for haerdib and murerfel September 14, 2022 09:47
clangenb
clangenb reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one general question, and one remark. Overall, I am in favor of using this!

@echevrier echevrier requested a review from clangenb September 14, 2022 11:29
@echevrier echevrier added B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing A0-core Affects a core part labels Sep 14, 2022
@echevrier echevrier marked this pull request as ready for review September 26, 2022 09:36
clangenb
clangenb approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@echevrier echevrier added A7-somethingelse and removed A0-core Affects a core part labels Sep 27, 2022
This was linked to issues Sep 27, 2022
Evaluate introduction of taplo for Cargo.toml formatting #957
Closed
Check cargo format in CI #1020
Closed
haerdib
haerdib approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@echevrier echevrier changed the title Test taplo: best config to match coding guidelines Add cargo.toml formatting with taplo Sep 28, 2022
@echevrier echevrier added B1-releasenotes and removed B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) labels Sep 28, 2022
@haerdib haerdib merged commit 4083b03 into master Sep 28, 2022
@echevrier echevrier deleted the ec_taplo branch September 29, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clangenb clangenb clangenb approved these changes

@haerdib haerdib haerdib approved these changes

Assignees

@echevrier echevrier

Labels

A7-somethingelse B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check cargo format in CI Evaluate introduction of taplo for Cargo.toml formatting

3 participants

@echevrier @clangenb @haerdib