Below are all the fixme/todo annotated points in our code.

Pallet Substratee Registry

registry/ias-verify line 298: Check report timestamp in runtime

🛑 registry/ias-verify line 338: what is meant there? (AB: I think this is obsolete. can't remember and don't see the problem)
🛑 registry line 44: remove pubkey from Enclave struct (AB: we shouldn't fix that now as it eases debugging)
🛑 registry line 121: Check sgx report status, is our setup fixed? (AB: do not fix for M7! to be fixed after encointer-worker deploy but we shouldn't be restrictive for testnet.)
🛑 registry line 134: rewrite unregister enclave, such that another enclave can unregister an enclave? Or better incorporate a heart beat and the runtime unregisters enclaves by itself. I believe this should rather be a future issue. (AB: yes, leave for future)

Enclave

attestation line 547: What is meant here? (AB: dunno. possibly obsolete?)
🛑 cert line 222: Redundant code from pallet-registry/ias-verify. As ias-verify is independent crate, we can import and use the code from there. (Edit: Not now, tackle only security issues)
🛑 lib line 471: redundant storage proof and storage value pass. (Edit: Not now, tackle only security issues)
🛑 lib line 571: Redundant worker request definition (Edit: Not now, tackle only security issues)
🛑 verify that worker is registered for specific shard. (Edit: Not M7)

STF

🛑 lib line 172: Signed return value (AB: yes, see #91 but actually, not in the deliverables for M7!)

sgx line 82 Check that only root account can use set_balance

Worker

tests line 50 + 58: Use root account in request
🛑 ecalls: implement tests for get_ecc_signing_pubkey, get_rsa_encryption_pubkey. (CL: Removed todos as I think that these are more expressively tested in the integration tests)

Fix fixme and todos #23

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions