Conversation
echevrier
left a comment
There was a problem hiding this comment.
Thank you very much. It is much better. The commands are valid and working. But I am missing some info, in case something goes wrong.
The references to the substrate documentation are good, but it is unpleasant that in order to ensure that the different steps work as they should, you always have to refer to them.
|
I'm not explaining the things too in depth, because I don't think this is a tutorial for beginners. There are tutorials from substrate to cover the basics, such as the meaning of the different ports and similar. This is a README for developers that know how starting a parachain works, but don't necessarily know all commands by heart yet. So as long as the commands in the README work, that is good enough. Covering all necessary debugging information would require a lot more work. Which might get outdated quite soon again. |
02ebff6 to
b8224cd
Compare
README.md
Outdated
| ./target/release/integritee-collator --collator --tmp --chain integritee-rococo-local-dev --port 40335 --ws-port 9946 -- --execution wasm --chain ../polkadot/rococo-local-cfde.json --port 30337 --ws-port 9981 | ||
| polkadot-launch launch-rococo-local-with-integritee.json | ||
| ``` | ||
| depending on how you installed `polkadot-launch`. |
There was a problem hiding this comment.
I would prefer if we set a team standard here. Go with the second option but explain how to install it that way
There was a problem hiding this comment.
Updated it accordingly. The installation needs to be globally such that the 2nd option can be used. But that's already in the installation part of polkadot-launch. So I simply put a Link there. Is that alright?
There was a problem hiding this comment.
whereas "global" means "across all projects of the current user", not system-wide for all users. then it's ok as it does not demand special privileges
~/.yarn/bin/polkadot-launch
There was a problem hiding this comment.
Yes, it's per user. At least if yarn has been installed for per-user. It didn't require any sudo command, in my case, neither for yarn nor for polkadot-launch with -g option.
brenzi
left a comment
There was a problem hiding this comment.
I like the simplification and decluttering.
Updates the README. Removed manual steps, but provided some necessary info (where to find id & cmds) to start it manually, in case it's necessary.
closes #92