Conversation
…a5dd27f3 : Deny using relay chain for reserve transfers
|
A runtime time upgrade performed successfully |
| use sp_version::NativeVersion; | ||
| use sp_version::RuntimeVersion; | ||
| // A few exports that help ease life for downstream crates. | ||
| use frame_support::weights::ConstantMultiplier; |
There was a problem hiding this comment.
Can you move this above the comment or make it pub? As it is now, the comment does not match the code.
| } | ||
|
|
||
| // See issue #5233 | ||
| pub struct DenyReserveTransferToRelayChain; |
There was a problem hiding this comment.
May I ask your reasoning for introducing this filter here? Because for HRMP we actually are using the relay chain for reserve transfer.
There was a problem hiding this comment.
Please check paritytech/polkadot#5233. We are not forced to use this filter.
However, I have changed the barrier's config, which could be wrong.
What is our goal?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Never mind the comment above, we need the DepositReserveAsset to other parachain accounts. And I don't see the use case where one would need to deposit to the relay chain account, so we can leave this filter be. Doesn't hurt.
There was a problem hiding this comment.
I guess we should keep this filter because:
- We don't need to transfer assets to the relay chain anyhow
- Reading this Not possible to
reserve_transfer_assetsback from Statemine to Kusama paritytech/polkadot#5233, I suppose that it would look funds that users can't recover.
set polkadot branch to release-v0.9.19
set substrate branch to polkadot-v0.9.19
set integritee-network pallets branch to polkadot-v0.9.19
set open-runtime-module-library branch to polkadot-v0.9.19
Add other changes :
replace match_type! with match_types!
add lengthToFee
add Sub-commands for benchmark
Deny using relay chain for reserve transfers
bump the runtime_version to 18