Add democracy pallet governance + fix benchmark script#118
Merged
Conversation
4ed8b56 to
a057782
Compare
clangenb
reviewed
May 9, 2022
Contributor
clangenb
left a comment
There was a problem hiding this comment.
Some questions, but I am happy that we achieve that with such a few lines of code!
| type Scheduler = Scheduler; | ||
| type PalletsOrigin = OriginCaller; | ||
| type MaxVotes = MaxVotes; | ||
| type WeightInfo = pallet_democracy::weights::SubstrateWeight<Runtime>; |
Contributor
There was a problem hiding this comment.
Same as above for the substrate weights.
clangenb
approved these changes
May 10, 2022
Contributor
clangenb
left a comment
There was a problem hiding this comment.
Looks good to me, cool!
clangenb
reviewed
May 11, 2022
haerdib
commented
May 13, 2022
Contributor
Author
haerdib
left a comment
There was a problem hiding this comment.
It looks good to me. Thanks for the input!
Contributor
Author
|
Should be ready to test on Rococo, IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds pallet democracy
adds a council
adds a technical committee
updates the benchmark script (fix + no need to list the pallet separately any more)
test runtime upgrade
test runtime upgrade via democracy pallet
benchmark pallet collective & democracy
closes #109