Fix a possible typo on setDismissalActorIDs#819
Closed
jarylc wants to merge 1 commit intointegrations:masterfrom
jarylc:bugfix/typo_on_setDismissalActorIDs
Closed
Fix a possible typo on setDismissalActorIDs#819jarylc wants to merge 1 commit intointegrations:masterfrom jarylc:bugfix/typo_on_setDismissalActorIDs
jarylc wants to merge 1 commit intointegrations:masterfrom
jarylc:bugfix/typo_on_setDismissalActorIDs
Conversation
…tection:push_restrictions users to not update frequently
jcudit
approved these changes
Jun 15, 2021
Contributor
jcudit
left a comment
There was a problem hiding this comment.
Looks correct. Hoping this ends up being the fix!
Contributor
|
I just found this after opening my PR (#824), which I believe is a slightly more complete fix, especially since the initial error has since propagated to another part of the file. |
Contributor
Author
|
@jcudit I believe there's a more complete fix for this in this PR by @usmonster Feel free to close this and work on that instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A simple PR for a typo.
There seems to be a typo in the setDismissalActorIDs func, this PR is to simply fix that if it was really unintended.
Reason
While using the provider, my team and I have realized that
github_branch_protection:push_restrictionsdoes not change on the first terraform application and somehow only gets queued for change on the second time. It was a really weird bug, and it might be due to this.If this PR is a non-issue, I will open an issue with more descriptions regarding it.