Skip to content

[MAINT] refactor github_repository_file to use Context-aware provider functions#3107

Merged
stevehipwell merged 10 commits intointegrations:mainfrom
F-Secure-web:refactor-repository_file-to-be-context-aware
Feb 3, 2026
Merged

[MAINT] refactor github_repository_file to use Context-aware provider functions#3107
stevehipwell merged 10 commits intointegrations:mainfrom
F-Secure-web:refactor-repository_file-to-be-context-aware

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Jan 21, 2026

Implements #2996 #3070 for github_repository_file

Before the change?

After the change?

  • github_repository_file uses Context-aware provider functions
  • Importer is extracted to it's own function
  • Added top-level Description field
  • Refactored to use tflog instead of log
  • Extracted a createBranch function to reduce duplication
  • Update validation logic to remove some conditional code

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 21, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga added r/repository_file Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jan 21, 2026
@deiga deiga added this to the v6.11.0 Release milestone Jan 25, 2026
@deiga deiga force-pushed the refactor-repository_file-to-be-context-aware branch from a79ec1c to 60c547a Compare January 29, 2026 20:38
stevehipwell
stevehipwell requested changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deiga this looks good. Just a couple of minor nits.

@deiga deiga requested a review from stevehipwell January 30, 2026 22:16
stevehipwell
stevehipwell requested changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deiga just one comment to look at otherwise, this is good to go.

@deiga deiga force-pushed the refactor-repository_file-to-be-context-aware branch from 6476bd3 to 181edb8 Compare February 3, 2026 16:01
@deiga deiga requested a review from stevehipwell February 3, 2026 16:01
stevehipwell
stevehipwell approved these changes Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Copy Markdown
Collaborator

stevehipwell commented Feb 3, 2026

@deiga could you please rebase this?

deiga added 10 commits February 3, 2026 18:46
@deiga
Refactor github_repository_file to use Context-aware functions for …
c246584 
…easier debugging

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Extract importer to separate function
f818f9a 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Add top-level Description field
08a770b 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Cleanup references/dereferences with github.Ptr
8551cb7 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Refactor to use tflog instead of log
24e2152 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Refactored the createBranch functionality into a function
0562a70 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Replace conditions with validation
7ce2b06 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Minor cleanup
920d2cc 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Address review comments
5d717c8 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Address review comments
5a8718a 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@stevehipwell stevehipwell enabled auto-merge (squash) February 3, 2026 17:02
auto-merge was automatically disabled February 3, 2026 17:06

Head branch was pushed to by a user without write access

@deiga deiga force-pushed the refactor-repository_file-to-be-context-aware branch from 181edb8 to 5a8718a Compare February 3, 2026 17:06
@stevehipwell stevehipwell merged commit d6daf6a into integrations:main Feb 3, 2026
7 checks passed
@mymasse mymasse mentioned this pull request Feb 5, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

@stevehipwell stevehipwell stevehipwell approved these changes

Assignees

No one assigned

Labels

r/repository_file Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Milestone

v6.11.0 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@deiga @stevehipwell @nickfloyd