Skip to content

fix: Escape environment name for id#3079

Merged
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:fix-environment-ids
Jan 15, 2026
Merged

fix: Escape environment name for id#3079
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:fix-environment-ids

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell commented Jan 14, 2026 •
edited
Loading

Resolves #3049
Resolves #3076
Resolves #2012

Before the change?

  • Environment name was being used directly in ID despite it being allowed to contain : (the ID separator)
  • github_repository_environment_deployment_policy would not work correctly with environment names requiring escaping

After the change?

  • Environment names are escaped correctly
  • github_repository_environment_deployment_policy works with environment names requiring escaping

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.10.0 Release milestone Jan 14, 2026
@stevehipwell stevehipwell self-assigned this Jan 14, 2026
@stevehipwell stevehipwell added the Type: Bug Something isn't working as documented label Jan 14, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell stevehipwell force-pushed the fix-environment-ids branch 3 times, most recently from 911ea24 to eb05dd2 Compare January 14, 2026 19:47
@stevehipwell stevehipwell mentioned this pull request Jan 14, 2026
Closed
5 tasks
@stevehipwell stevehipwell force-pushed the fix-environment-ids branch 2 times, most recently from 5038f82 to 5ef9303 Compare January 15, 2026 10:10
@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Jan 15, 2026

Resolves #3076
Resolves #2012

@stevehipwell
fix: Escape environment name for id
09fbbad 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell enabled auto-merge (squash) January 15, 2026 15:42
@stevehipwell stevehipwell merged commit d4d121f into integrations:main Jan 15, 2026
8 checks passed
@stevehipwell stevehipwell deleted the fix-environment-ids branch January 15, 2026 15:50
@stevehipwell stevehipwell mentioned this pull request Jan 27, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment