feat: Add team notification settings#3059
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
4992ba3 to
ae4de2c
Compare
|
@stevehipwell Could you elaborate why this has changed to deprecated? This functionality is very much needed. If you are not org admin, you cannot add members to a team and your team will be unmanageable without this option. So this is not a valid substitute: Use github_team_membership or github_team_members resource to manage team memberships explicitly. Thank you |
|
@enricojonas the current implementation isn't correct or maintainable, but the functionality isn't going away for non-privileged users. A solution for non-admin team creation will be added in a maintainable way with an API that aligns with the way the provider is intended to be used. Please follow #3135 for more information. |
Resolves #2532
Before the change?
After the change?
github_teamhasnotification_settinggithub_teamhasnotification_settingPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!