Skip to content

feat: Add team notification settings#3059

Merged
nickfloyd merged 1 commit intointegrations:mainfrom
stevehipwell:team-notification-settings
Jan 7, 2026
Merged

feat: Add team notification settings#3059
nickfloyd merged 1 commit intointegrations:mainfrom
stevehipwell:team-notification-settings

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

Resolves #2532


Before the change?

  • No support for notification setting

After the change?

  • Data source github_team has notification_setting
  • Resource github_team has notification_setting

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.10.0 Release milestone Jan 7, 2026
@stevehipwell stevehipwell requested a review from nickfloyd January 7, 2026 18:47
@stevehipwell stevehipwell self-assigned this Jan 7, 2026
@stevehipwell stevehipwell added the Type: Feature New feature or request label Jan 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell force-pushed the team-notification-settings branch from 4992ba3 to ae4de2c Compare January 7, 2026 20:37
@nickfloyd nickfloyd merged commit d5f775e into integrations:main Jan 7, 2026
8 checks passed
@stevehipwell stevehipwell deleted the team-notification-settings branch January 7, 2026 22:01
@enricojonas
Copy link
Copy Markdown

@stevehipwell Could you elaborate why this has changed to deprecated?

			"create_default_maintainer": {
				Type:        schema.TypeBool,
				Optional:    true,
				Default:     false,
				Description: "Adds a default maintainer to the team. Adds the creating user to the team when 'true'.",
				Deprecated:  "Use github_team_membership or github_team_members resource to manage team memberships explicitly.",
			},

This functionality is very much needed. If you are not org admin, you cannot add members to a team and your team will be unmanageable without this option.

So this is not a valid substitute: Use github_team_membership or github_team_members resource to manage team memberships explicitly.

Thank you

@stevehipwell
Copy link
Copy Markdown
Collaborator Author

@enricojonas the current implementation isn't correct or maintainable, but the functionality isn't going away for non-privileged users. A solution for non-admin team creation will be added in a maintainable way with an API that aligns with the way the provider is intended to be used. Please follow #3135 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Add support for notification_setting to the github_team resource and data source

3 participants