Skip to content

[BUG] Enable importing github_emu_group_mapping for Group with multiple teams#3043

Closed
deiga wants to merge 7 commits intointegrations:refactor-integration-testsfrom
F-Secure-web:fix-emu-group-mapping-import-multiple-teams-3030
Closed

[BUG] Enable importing github_emu_group_mapping for Group with multiple teams#3043
deiga wants to merge 7 commits intointegrations:refactor-integration-testsfrom
F-Secure-web:fix-emu-group-mapping-import-multiple-teams-3030

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Jan 5, 2026

Resolves #3030


Before the change?

  • No tests for github_emu_group_mapping
  • Import set wrong ID
  • Not able to import Groups with multiple teams mapped
  • Using legacy CRUD provider functions

After the change?

  • Adds tests for github_emu_group_mapping
  • Fixes import logic
  • Enabled importing Group with multiple team mappings
  • Refactor to use Context-aware functions

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

stevehipwell and others added 7 commits December 19, 2025 16:55
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Which was found by our new tests!

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions github-actions bot added the Type: Bug Something isn't working as documented label Jan 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch 6 times, most recently from 241055a to 581b507 Compare January 6, 2026 20:01
@stevehipwell stevehipwell deleted the branch integrations:refactor-integration-tests January 6, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants