👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@tempora-mutantur Could you please resolve the conflicts? 🙏

@tempora-mutantur Could you please resolve the conflicts? 🙏

Done. Thanks

@deiga

After rebasing, I re-ran tests including the GH_TEST_AUTH_MODE=anonymous configuration. I found that the provider now requires either token or app_auth to be specified (e.g., via GITHUB_TOKEN environment variable). Without it, I get:

        Error: Invalid combination of arguments
        
          with provider["registry.terraform.io/hashicorp/github"],
          on terraform_plugin_test.tf line 2, in provider "github":
           2:           provider "github" {
        
        "token": one of `app_auth,token` must be specified

The issue appears to be caused by using ExactlyOneOf validation in the provider schema:

https://github.com/integrations/terraform-provider-github/blob/main/github/provider.go#L25

ExactlyOneOf requires that exactly one of the specified fields must be set, which prevents anonymous mode from working when neither token nor app_auth are set.

I tested the "can be configured to run anonymously" test case by removing the line

https://github.com/integrations/terraform-provider-github/blob/main/github/provider_test.go#L57

to test this

https://github.com/integrations/terraform-provider-github/blob/main/website/docs/index.html.markdown?plain=1#L32

It failed with: "app_auth": one of 'app_auth,token' must be specified

        Error: Invalid combination of arguments
        
          with provider["registry.terraform.io/hashicorp/github"],
          on terraform_plugin_test.tf line 2, in provider "github":
           2:           provider "github" {
        
        "token": one of `app_auth,token` must be specified

Maybe we could use ConflictsWith instead of ExactlyOneOf if we want to allow providers with no auth config.

@tempora-mutantur I think I actually made the decision conciously that for anonymous access one would need to set token = "" in the provider.

But I didn't document that and I didn't run this past the other maintainers properly either

There is now a PR to address that #3071

@nickfloyd could you please review this.

@tempora-mutantur could you please rebase this PR?