Skip to content

[MAINT] Improve provider tests#3033

Closed
deiga wants to merge 10 commits intointegrations:refactor-integration-testsfrom
F-Secure-web:improve-provider-tests
Closed

[MAINT] Improve provider tests#3033
deiga wants to merge 10 commits intointegrations:refactor-integration-testsfrom
F-Secure-web:improve-provider-tests

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Jan 1, 2026

Before the change?

  • It was possible to inadvertently set token and app_auth at the same time
  • Some provider test's weren't actually testing anything

After the change?

  • Ensures that token (or GITHUB_TOKEN) and app_auth can't be set at the same time
  • Updated some provider tests to actually initialize the provider and verify changes

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

stevehipwell and others added 7 commits December 19, 2025 16:55
@stevehipwell
chore: Refactor integration tests
450176c 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@deiga
Ensure that token is never configured together with app_auth
73fd9d7 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Add test to verify that GITHUB_TOKEN and app_auth are not set at …
b6c3795 
…the same time

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Ensure max_per_page test actually runs
bb89bf7 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Ensure max_retries is actually tested
544465a 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Fix indentation
22c7e20 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Use ExactlyOneOf instead of ConflictsWith
11e44a9 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

deiga added 3 commits January 2, 2026 08:52
@deiga
Add some more infor logging
6dd3c85 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Fix brackets
dc49bf5 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Update Org test to ensure it actually tests
b0216d6 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch 6 times, most recently from 241055a to 581b507 Compare January 6, 2026 20:01
@stevehipwell stevehipwell deleted the branch integrations:refactor-integration-tests January 6, 2026 20:07
@deiga deiga mentioned this pull request Jan 7, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deiga @stevehipwell