[MAINT] Add regression test for #2614#3032
Closed
deiga wants to merge 3 commits intointegrations:refactor-integration-testsfrom
Closed
[MAINT] Add regression test for #2614#3032deiga wants to merge 3 commits intointegrations:refactor-integration-testsfrom
deiga wants to merge 3 commits intointegrations:refactor-integration-testsfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…her prevents replacement of externally modified secret Signed-off-by: Timo Sand <timo.sand@f-secure.com>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
241055a to
581b507
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroy_on_driftandignore_changestogether prevents replacement of externally modified secretBefore the change?
destoy_on_drift = falseandlifecycle.ignore_changes = [plaintext_value, encryped_value]would not update plan on external changesAfter the change?
destoy_on_drift = falseandlifecycle.ignore_changes = [plaintext_value, encryped_value]Pull request checklist
Schema migrations have been created if needed (example)Docs have been reviewed and added / updated if needed (for bug fixes / features)Does this introduce a breaking change?
Please see our docs on breaking changes to help!